[996] Add features to write multi block tests #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravahuja
requested review from
DavePearce,
powerslider,
bogdanbear and
arijitdutta67
DavePearce
reviewed
Sep 15, 2024
| @@ -48,7 +48,7 @@ public class ToyAccount implements MutableAccount { | |||
| private Wei balance; | |||
| private Bytes code; | |||
| private Supplier<Hash> codeHash = Suppliers.memoize(() -> Hash.hash(code)); | |||
| private final Map<UInt256, UInt256> storage = new HashMap<>(); | |||
| final Map<UInt256, UInt256> storage = new HashMap<>(); | |||
There was a problem hiding this comment.
I would think getter / setters here is better than making it package visible.
DavePearce
approved these changes
Sep 15, 2024
|
@gauravahuja is this PR ready to be merged ? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#996