Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

use CliqueProtocolSchedule instead of MainnetProtocolSchedule to extr… #1222

Merged
merged 8 commits into from
Sep 19, 2024

Conversation

daniellehrner
Copy link
Collaborator

…act the correct coinbase value

This updates the replay tests which now pass.
This updates `linea-constraints` to ensure tests pass as expected.  Some
tests in `arith-dev` were previously failing, and this resolves that.
@DavePearce DavePearce marked this pull request as ready for review September 19, 2024 06:42
@letypequividelespoubelles
Copy link
Collaborator

letypequividelespoubelles commented Sep 19, 2024

It seems it doesn't impact the coinbase address we get in Block.java ? Am I missing something ?

During tracing, this is where we read the coinbase address to then write it where needed in .lt trace.

Edit: my bad, when running test, It's now not 0x00 but smtg else.

@DavePearce DavePearce self-requested a review September 19, 2024 08:29
Copy link
Collaborator

@DavePearce DavePearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavePearce DavePearce merged commit c878170 into arith-dev Sep 19, 2024
6 checks passed
@DavePearce DavePearce deleted the fix/use-clique-protocol-schedule branch September 19, 2024 08:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants