test: test CI using smaller runner #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gauravahuja
commented
Sep 19, 2024
•
gauravahuja
commented
- Use a smaller 8 core runner vs 32 core
- Remove spotless as a separate workflow and include it as part of the build workflow
- The separate spotless workflow uncessary instantiated another runner, downloaded the repo and jdk.
- Initialize only the linea-constraints submodule and exclude the ethereum-tests submodule. The ethereum-test submodule is about 1-2GB and only needed for reference tests and thus not required for CI on every commit.
| submodules: false | ||
|
|
||
| - name: Get Submodules | ||
| run: git submodule update --init --recursive linea-constraints |
There was a problem hiding this comment.
Does this means it will update the submodule to the latest master in every PR ? If yes, it shouldn't be the case, while debugging, we need to point to a specific constraint commit
There was a problem hiding this comment.
My understanding is that it will update the submodule to the version specified in the .gitmodules file
powerslider
approved these changes
Sep 19, 2024
powerslider
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.