Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Homogenize creation add operation #1314

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

letypequividelespoubelles
Copy link
Collaborator

No description provided.

Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
Copy link
Collaborator

@OlivierBBB OlivierBBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also the OobOperation.java's callToADD that uses add.callADD(arg1, arg2) where

    final EWord arg1 = EWord.of(arg1Hi, arg1Lo);
    final EWord arg2 = EWord.of(arg2Hi, arg2Lo);

I.e. we're feeding it EWord rather than Bytes32

@letypequividelespoubelles
Copy link
Collaborator Author

letypequividelespoubelles commented Sep 25, 2024

There is also the OobOperation.java's callToADD that uses add.callADD(arg1, arg2) where

    final EWord arg1 = EWord.of(arg1Hi, arg1Lo);
    final EWord arg2 = EWord.of(arg2Hi, arg2Lo);

I.e. we're feeding it EWord rather than Bytes32

This is the only place where we call ADD in fact. But when I try to cast the EWord in a Bytes32 intelliJ tells me it won't do anything, as EWord is an implementation of Bytes32 ...

Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
@OlivierBBB OlivierBBB self-requested a review September 25, 2024 17:37
Copy link
Collaborator

@OlivierBBB OlivierBBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlivierBBB OlivierBBB enabled auto-merge (squash) September 25, 2024 17:37
final EWord arg1 = EWord.of(arg1Hi, arg1Lo);
final EWord arg2 = EWord.of(arg2Hi, arg2Lo);
final Bytes32 arg1 = EWord.of(arg1Hi, arg1Lo);
final Bytes32 arg2 = EWord.of(arg2Hi, arg2Lo);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is very strange ^^ but it seems to not raise an issue

@OlivierBBB OlivierBBB disabled auto-merge September 25, 2024 17:39
@OlivierBBB OlivierBBB enabled auto-merge (squash) September 25, 2024 17:39
@OlivierBBB OlivierBBB merged commit 5544303 into arith-dev Sep 25, 2024
5 checks passed
@OlivierBBB OlivierBBB deleted the homogenize-creation-add-operation branch September 25, 2024 18:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants