-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Homogenize creation add operation #1314
Conversation
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also the OobOperation.java
's callToADD
that uses add.callADD(arg1, arg2)
where
final EWord arg1 = EWord.of(arg1Hi, arg1Lo);
final EWord arg2 = EWord.of(arg2Hi, arg2Lo);
I.e. we're feeding it EWord
rather than Bytes32
This is the only place where we call |
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
final EWord arg1 = EWord.of(arg1Hi, arg1Lo); | ||
final EWord arg2 = EWord.of(arg2Hi, arg2Lo); | ||
final Bytes32 arg1 = EWord.of(arg1Hi, arg1Lo); | ||
final Bytes32 arg2 = EWord.of(arg2Hi, arg2Lo); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is very strange ^^ but it seems to not raise an issue
No description provided.