Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test(shf): add extensive test #1320

Merged
merged 10 commits into from
Oct 1, 2024
Merged

test(shf): add extensive test #1320

merged 10 commits into from
Oct 1, 2024

Conversation

lorenzogentile404
Copy link
Collaborator

No description provided.

@lorenzogentile404 lorenzogentile404 linked an issue Sep 27, 2024 that may be closed by this pull request
SHF extensive testing #1319
Closed
@OlivierBBB
Copy link
Collaborator

OlivierBBB commented Sep 27, 2024 •
edited
Loading

We would need a tag to run weekly checks or so @gauravahuja . This tag should apply to several extensive test families, in particular

  • EXP
  • SHF
  • (to come) MOD for signed instructions

@lorenzogentile404 lorenzogentile404 marked this pull request as ready for review September 28, 2024 21:38
@lorenzogentile404 lorenzogentile404 self-assigned this Sep 28, 2024
OlivierBBB
OlivierBBB reviewed Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@OlivierBBB OlivierBBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only thing I'm not convinced about is keeping the old, granular version of the test. It would make sense I guess had we had bugs, but that wasn't the case. So I would be in favour of deleting that part of the code.

@OlivierBBB OlivierBBB self-requested a review September 30, 2024 12:49
@lorenzogentile404 lorenzogentile404 merged commit fabcb54 into arith-dev Oct 1, 2024
5 checks passed
@lorenzogentile404 lorenzogentile404 deleted the 1319-shf-extensive-testing branch October 1, 2024 13:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@OlivierBBB OlivierBBB OlivierBBB approved these changes

Assignees

@lorenzogentile404 lorenzogentile404

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SHF extensive testing
2 participants
@lorenzogentile404 @OlivierBBB