Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixing issues related to tracing all blocks in the reference tests #1350

Conversation

OlivierBBB
Copy link
Collaborator

No description provided.

- extract chainId and provide it to the ZkTracer
- create a single ZkTracer
- corset check done at the end of the for loop over all blocks

The final point resolves the issue where we only played one block in any
reference test
Copy link
Collaborator

@lorenzogentile404 lorenzogentile404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I suggest to just add a comment about the temporary dummy value for chainId.

@OlivierBBB OlivierBBB enabled auto-merge (squash) October 2, 2024 15:22
@OlivierBBB OlivierBBB disabled auto-merge October 2, 2024 15:22
@OlivierBBB OlivierBBB merged commit 922b784 into arith-dev Oct 2, 2024
3 checks passed
@OlivierBBB OlivierBBB deleted the 1349-fixing-issues-related-to-tracing-all-blocks-in-the-reference-tests branch October 2, 2024 15:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants