fix: nightly tests #1355
Merged
fix: nightly tests #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavePearce
force-pushed
the
fix/issue-1353/fix-nightly-tests
branch
from
f702261 to
f998084
Compare
This (hopefully) fixes the nightly tests by: (1) no longer supporting `corset` for checking constraints (since this runs out of memory on large traces); (2) uploads the test report after `go-corset` has run. That will then allow us to see what has gone wrong.
This re-enables output to be written to the Github action console for failing tests. This has been previously disabled for reasons unknown, but it ends up hiding important information.
DavePearce
force-pushed
the
fix/issue-1353/fix-nightly-tests
branch
from
f998084 to
bfb1805
Compare
powerslider
approved these changes
Oct 2, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the first step towards properly fixing the nightly tests.