fix: resolve failing tests #1373 #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavePearce
force-pushed
the
1373-investigate-go-corset-and-leofailingrange-on-ci-server
branch
2 times, most recently
from
3031b90 to
d30b4ce
Compare
DavePearce
force-pushed
the
1373-investigate-go-corset-and-leofailingrange-on-ci-server
branch
8 times, most recently
from
4c33832 to
b847110
Compare
This was previously failing after updating from corset v9.7.13 to v9.7.14. This change exposed some performance limitations in go-corset which have hopefully been addressed.
This updates the configuration file to use latest versions of relevant components, and also to prevent running `gradle check` for each commit. Since this runs all known tests, it would take possibly over an hour to complete on a laptop.
This tweaks the CI pipline configuration for `go-corset` to try and get some better settings. Also, moves a test which doesn't pass into the nightly tests (since these are run on a larger machine).
DavePearce
force-pushed
the
1373-investigate-go-corset-and-leofailingrange-on-ci-server
branch
from
b847110 to
ad4d049
Compare
This fixes the failing nightly test `issue_1216_mainnet_2321460_2321556` by marking it `@Disabled`. This test seems to use too much RAM for `go-corset` on the CI machine.
powerslider
approved these changes
Oct 10, 2024
DavePearce
deleted the
1373-investigate-go-corset-and-leofailingrange-on-ci-server
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to resolve a test which was failing in the CI pipeline (but now should not, since we have hosted runners). This also updates the
.pre-commit-config.yamlfile.