fix: Use correct CHAINID in EVM #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@powerslider I am not so certain about changes to the |
DavePearce
force-pushed
the
fix/issue-940/incorrect-chainid-used-in-toyexecutionenvironment
branch
from
56885d0 to
c9575cf
Compare
This updates the `ToyExecutionEnvironment` to use the correct CHAINID when constructing the EVM. Previously, this was not done correctly and meant that the `CHAINID` bytecode was returning an invalid value, which in turn mean that storage addresses were being computed incorrectly (i.e. because they incorporated the CHAINID into the hash).
DavePearce
force-pushed
the
fix/issue-940/incorrect-chainid-used-in-toyexecutionenvironment
branch
from
c9575cf to
b206f8a
Compare
powerslider
deleted the
fix/issue-940/incorrect-chainid-used-in-toyexecutionenvironment
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
ToyExecutionEnvironmentto use the correct CHAINID when constructing the EVM. Previously, this was not done correctly and meant that theCHAINIDbytecode was returning an invalid value, which in turn mean that storage addresses were being computed incorrectly (i.e. because they incorporated the CHAINID into the hash).