Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feat/issue 944/implement txn data update handling the max nonce #987

Merged
merged 504 commits into from
Aug 27, 2024
Merged

Feat/issue 944/implement txn data update handling the max nonce #987

merged 504 commits into from
Aug 27, 2024

Conversation

letypequividelespoubelles
Copy link
Collaborator

No description provided.

OlivierBBB and others added 30 commits July 22, 2024 00:08
@OlivierBBB
feat(return): wip
36b5e0f
@letypequividelespoubelles
feat(return): implement mmu call invalid code prefix
721dc9d
@lorenzogentile404
feat(selfdestruct): review and complete will revert case
962736e
@lorenzogentile404
feat(selfdestruct): added comments
2fe118f
@lorenzogentile404
ras
ea70c7d
@letypequividelespoubelles
clean stuff
15088ab
@lorenzogentile404
feat(selfdestruct): started implementing self destruct map
a6e2be9
@lorenzogentile404
feat(selfdestruct): rename components of the map
809ce42
@lorenzogentile404
feat(selfdestruct): implement resolvePostTransaction
5709e8a
@OlivierBBB
ras
4b88891
@OlivierBBB
feat(return): progress but some TODO's
f86f88f
@letypequividelespoubelles
delete the failure signals, delete romLex signals, triggers romLex fo…
c811307 
…r CREATE, seal sections for CN/CNnew
@letypequividelespoubelles
Merge branch 'arith-dev' into feat/issue-746/linea-transaction-class
7e9840a
@letypequividelespoubelles
merge arith-dev
e4e9b4d
@letypequividelespoubelles
rm void file
9bc9257
@lorenzogentile404
feat(selfdestruct): cleaned code
99192b7
@letypequividelespoubelles
Merge branch 'arith-dev' into feat/issue-746/linea-transaction-class
48feb35
@letypequividelespoubelles
fix resolve defers after triggering module at endTx
ce4101a
@letypequividelespoubelles
fix: need to do two rounds of defersPostTx
39d1312
@letypequividelespoubelles
Merge branch 'arith-dev' into feat/issue-746/linea-transaction-class
70c97fe
@letypequividelespoubelles
Merge branch 'arith-dev' into feat/issue-746/linea-transaction-class
389aba6
@letypequividelespoubelles
extcodecopy triggers RomLex
938927a
@letypequividelespoubelles
Merge branch 'feat/issue-746/linea-transaction-class' of github.com:C…
c4156ec 
…onsensys/linea-arithmetization into feat/issue-746/linea-transaction-class
@lorenzogentile404
feat(selfdestruct): fixed resolvePostTransaction
7027263
@letypequividelespoubelles
fix(return): triggers ROMLEX
90d2df2
@OlivierBBB
fix(stuff): various
a392785
@letypequividelespoubelles
spotless + clean
f784b76
@lorenzogentile404
feat(account fragment): implemented marked for selfdestruct
4e1934a
@lorenzogentile404
fix(self destruct time): renaming
34c55b4
@lorenzogentile404
fix(account fragment): fix account fragment resolve post transaction
4edce05
OlivierBBB and others added 24 commits August 24, 2024 01:43
@OlivierBBB
feat: traceMe() method for MmuOperation
49ed5c8
@letypequividelespoubelles
spotless + fix untraced MMU op in mmio
9658d93 
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
@letypequividelespoubelles
Merge branch 'arith-dev' into feat/issue-746/linea-transaction-class
b5f8f40
@letypequividelespoubelles
fix make it build
029cdbc 
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
@letypequividelespoubelles
fix successBit in invalidCodePrefix MmuCall
acafb72 
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
@letypequividelespoubelles
fix: aborting calls defers at childContextEntry
d917467 
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
@letypequividelespoubelles
fix postOpcode acc snapshot for aborting calls
889a04e 
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
@letypequividelespoubelles
cleanup
4e5f9ab 
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
@lorenzogentile404
docs(hub): add comment related to creator nonce
88088f8
@lorenzogentile404
fix(ecdata): partial fix
e6f91fb
@OlivierBBB
fix(ecdata): call data has to be right padded + 100% valid padded cal…
707d5c4 
…l data length

# Conflicts:
#	arithmetization/src/main/java/net/consensys/linea/zktracer/module/ecdata/EcDataOperation.java
@OlivierBBB
fix(ecdata): ensure that EcData has nonempty call data + renaming
1069e3f
@lorenzogentile404
spotless
e8aea36
@OlivierBBB
feat(ecrecover): ultra simple failing test
3fe62a8
@lorenzogentile404
fix(ecdata): re-enable tracing and line counting disregarding success…
99f62a3 
… bit value
@lorenzogentile404
spotless
9581e56
@letypequividelespoubelles
feat(txndata): inmplement EIP2681
89fabc4 
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
@letypequividelespoubelles
Merge branch 'feat/issue-746/linea-transaction-class' into 944-implem…
734fa21 
…ent-txn_data-update-handling-the-max_nonce
@letypequividelespoubelles
Merge branch 'arith-dev' into 944-implement-txn_data-update-handling-…
115326d 
…the-max_nonce
@letypequividelespoubelles
fix(txndata): trivial fix
8a1abd5 
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
@letypequividelespoubelles
Merge branch 'arith-dev' into 944-implement-txn_data-update-handling-…
95d3dc3 
…the-max_nonce
@letypequividelespoubelles
fix: wrong data cost calculation that contains the deployement cost
8668d70 
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
@letypequividelespoubelles
Merge branch '944-implement-txn_data-update-handling-the-max_nonce' o…
26e0adf 
…f github.com:Consensys/linea-tracer into 944-implement-txn_data-update-handling-the-max_nonce
@letypequividelespoubelles
Merge branch 'arith-dev' into 944-implement-txn_data-update-handling-…
906efde 
…the-max_nonce
@letypequividelespoubelles letypequividelespoubelles linked an issue Aug 27, 2024 that may be closed by this pull request
Implement TXN_DATA update handling the MAX_NONCE #944
Closed
OlivierBBB
OlivierBBB approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@OlivierBBB OlivierBBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlivierBBB OlivierBBB merged commit 1466038 into arith-dev Aug 27, 2024
10 checks passed
@OlivierBBB OlivierBBB deleted the feat/issue-944/implement-txn_data-update-handling-the-max_nonce branch August 27, 2024 16:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@OlivierBBB OlivierBBB OlivierBBB approved these changes

@lorenzogentile404 lorenzogentile404 Awaiting requested review from lorenzogentile404

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement TXN_DATA update handling the MAX_NONCE
5 participants
@letypequividelespoubelles @OlivierBBB @lorenzogentile404 @FlorianHuc @powerslider