Fix bug in resolving log message of user assertion #1784
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mythril/mythril/analysis/module/modules/user_assertions.py
Lines 71 to 81 in ca2dc13
The function
decode_single()
at L72 resolves log messages of user assertions. However, referring to the release notes of eth_abi, the function will return a pythonstr
instead ofbytes
if called with ABI type "string" since v2.0.0-alpha.1. Thus, the function will always fail silently as all exceptions will be catched by theexcept
statement at L80.