Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Landing Pages: Remove jQuery #32

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Landing Pages: Remove jQuery #32

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fea79a
Remove jQuery dependency injection for Landing Pages
n7studios Jan 9, 2024
1f705f3
Fix undefined variable; remove unused `WP_Scripts` class
n7studios Jan 9, 2024
85327cf
Coding standards
n7studios Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/class-convertkit-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1497,9 +1497,7 @@ public function get_landing_page_html( $url ) {
// Inject JS for subscriber forms to work.
// wp_enqueue_script() isn't called when we load a Landing Page, so we can't use it.
// phpcs:disable WordPress.WP.EnqueuedResources
$scripts = new WP_Scripts();
$script = "<script type='text/javascript' src='" . trailingslashit( $scripts->base_url ) . "wp-includes/js/jquery/jquery.js?ver=1.4.0'></script>";
$script .= "<script type='text/javascript' src='" . $this->plugin_url . 'resources/frontend/js/convertkit.js?ver=' . $this->plugin_version . "'></script>";
$script = "<script type='text/javascript' src='" . $this->plugin_url . 'resources/frontend/js/convertkit.js?ver=' . $this->plugin_version . "'></script>";
$script .= "<script type='text/javascript'>/* <![CDATA[ */var convertkit = {\"ajaxurl\":\"" . admin_url( 'admin-ajax.php' ) . '"};/* ]]> */</script>';
// phpcs:enable

Expand Down
Loading