Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

preparing react18 #2584

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

preparing react18 #2584

wants to merge 2 commits into from

Conversation

chrisdugne
Copy link
Contributor

Detailed purpose of the PR

Result and observation

  • Breaking changes ?
    If checked, what have you broken ?

  • Extra lib ?
    If checked, Which extra lib did you add ? (name, purpose, link ...).

Testing Strategy

  • Already covered by tests
  • Manual testing
  • Unit testing

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #2584 (6857b84) into master (fb712e9) will decrease coverage by 19.52%.
The diff coverage is n/a.

❗ Current head 6857b84 differs from pull request most recent head 761cdd6. Consider uploading reports for the commit 761cdd6 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2584       +/-   ##
===========================================
- Coverage   94.84%   75.32%   -19.52%     
===========================================
  Files         333      346       +13     
  Lines        4966     5338      +372     
  Branches      214      214               
===========================================
- Hits         4710     4021      -689     
- Misses        220     1314     +1094     
+ Partials       36        3       -33     
Impacted Files Coverage Δ
...academy-components/src/atom/space/index.native.tsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/atom/review-header-step-item/index.native.tsx 7.14% <0.00%> (-92.86%) ⬇️
...cademy-components/src/atom/choice/index.native.tsx 5.71% <0.00%> (-88.58%) ⬇️
...ents/src/atom/review-presentation/index.native.tsx 12.00% <0.00%> (-88.00%) ⬇️
...lecule/questions/mobile/draggable/index.native.tsx 12.12% <0.00%> (-87.88%) ⬇️
...ponents/src/hoc/modal/select-item/index.native.tsx 12.50% <0.00%> (-87.50%) ⬇️
...ts/src/template/app-review/skills/index.native.tsx 13.33% <0.00%> (-86.67%) ⬇️
.../src/organism/podcast-popin-intro/index.native.tsx 13.33% <0.00%> (-86.67%) ⬇️
.../molecule/review-correction-popin/index.native.tsx 13.79% <0.00%> (-86.21%) ⬇️
...-components/src/molecule/cm-popin/index.native.tsx 14.28% <0.00%> (-85.72%) ⬇️
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54e9514...761cdd6. Read the comment docs.

@chrisdugne chrisdugne marked this pull request as draft January 17, 2023 19:54
@chrisdugne chrisdugne self-assigned this Jan 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant