Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Release 4 #532

Closed
ivanperez-keera opened this issue Sep 6, 2024 · 6 comments
Closed

Release 4 #532

ivanperez-keera opened this issue Sep 6, 2024 · 6 comments
Assignees
Labels
CR:Status:Closed Admin only: Change request that has been completed CR:Type:Management Admin only: Change request for conformance with policies or procedures
Milestone

Comments

@ivanperez-keera
Copy link
Member

Description

Version 4 of Copilot should be closed and published on Hackage.

Type

  • Management: release and publication.

Additional context

None.

Requester

  • Ivan Perez.

Method to check presence of bug

Not applicable (not a bug).

Expected result

  • Cabal files indicate new version number, constraints are adjusted as needed, commit is tagged with version number, and packages are published on hackage.

Desired result

  • Cabal files indicate new version number, constraints are adjusted as needed, commit is tagged with version number, and packages are published on hackage.

Proposed solution

  • Cabal files indicate new version number, constraints are adjusted as needed, commit is tagged with version number, and packages are published on hackage.

Further notes

None.

@ivanperez-keera ivanperez-keera added CR:Type:Management Admin only: Change request for conformance with policies or procedures CR:Status:Initiated Admin only: Change request that has been initiated labels Sep 6, 2024
@ivanperez-keera
Copy link
Member Author

Change Manager: Confirmed version is ready to be released.

@ivanperez-keera ivanperez-keera added CR:Status:Confirmed Admin only: Change request that has been acknowledged by the change manager and removed CR:Status:Initiated Admin only: Change request that has been initiated labels Sep 7, 2024
@ivanperez-keera
Copy link
Member Author

Technical Lead: Confirmed that the issue should be addressed.

@ivanperez-keera ivanperez-keera added CR:Status:Accepted Admin only: Change request accepted by technical lead and removed CR:Status:Confirmed Admin only: Change request that has been acknowledged by the change manager labels Sep 7, 2024
@ivanperez-keera
Copy link
Member Author

Technical Lead: Issue scheduled for Copilot 4.

Fix assigned to: @ivanperez-keera.

@ivanperez-keera ivanperez-keera added CR:Status:Scheduled Admin only: Change requested scheduled and removed CR:Status:Accepted Admin only: Change request accepted by technical lead labels Sep 7, 2024
@ivanperez-keera ivanperez-keera added this to the Copilot 4 milestone Sep 7, 2024
@ivanperez-keera ivanperez-keera self-assigned this Sep 7, 2024
@ivanperez-keera ivanperez-keera added CR:Status:Implementation Admin only: Change request that is currently being implemented and removed CR:Status:Scheduled Admin only: Change requested scheduled labels Sep 8, 2024
ivanperez-keera added a commit to ivanperez-keera/copilot that referenced this issue Sep 8, 2024
ivanperez-keera added a commit to ivanperez-keera/copilot that referenced this issue Sep 8, 2024
@ivanperez-keera
Copy link
Member Author

Implementor: Solution implemented, review requested.

@ivanperez-keera ivanperez-keera added CR:Status:Verification Admin only: Change request that is currently being verified and removed CR:Status:Implementation Admin only: Change request that is currently being implemented labels Sep 8, 2024
@ivanperez-keera
Copy link
Member Author

Change Manager: Verified that:

  • Solution is implemented:
    • The code proposed compiles and passes all tests. Details:
      Build log: https://app.travis-ci.com/github/Copilot-Language/copilot/builds/272222180

    • The solution proposed addresses the necessary modification to cabal packages. The following docker image installs copilot enforcing the new version via compiler constraints. It prints the message "Success" at the end if all completes correctly, and shows an error message otherwise.

      FROM ubuntu:focal
      
      ENV DEBIAN_FRONTEND=noninteractive
      
      RUN apt-get update
      
      RUN apt-get install --yes libz-dev pkg-config
      RUN apt-get install --yes git
      
      RUN apt-get install --yes wget
      RUN mkdir -p $HOME/.ghcup/bin
      RUN wget https://downloads.haskell.org/~ghcup/0.1.17.7/x86_64-linux-ghcup-0.1.17.7 -O $HOME/.ghcup/bin/ghcup
      
      RUN chmod a+x $HOME/.ghcup/bin/ghcup
      ENV PATH=$PATH:/root/.ghcup/bin/
      ENV PATH=$PATH:/root/.cabal/bin/
      RUN apt-get install --yes curl
      RUN apt-get install --yes gcc g++ make libgmp3-dev
      RUN ghcup install ghc 9.8.2
      RUN ghcup install cabal 3.4
      RUN ghcup set ghc 9.8.2
      RUN cabal update
      
      SHELL ["/bin/bash", "-c"]
      CMD git clone $REPO \
          && cd $NAME \
          && git checkout $COMMIT \
          && cabal install --lib copilot**/ \
               --constraint="copilot==4.0" \
               --constraint="copilot-c99==4.0" \
               --constraint="copilot-core==4.0" \
               --constraint="copilot-prettyprinter==4.0" \
               --constraint="copilot-interpreter==4.0" \
               --constraint="copilot-language==4.0" \
               --constraint="copilot-libraries==4.0" \
               --constraint="copilot-theorem==4.0" \
          && echo Success

      Command (substitute variables based on new path after merge):

      $ docker run -e "REPO=https://github.com/ivanperez-keera/copilot" -e "NAME=copilot" -e "COMMIT=2cea27decb7c62b375800f8b4bc1fdfa78433034" -it copilot-verify-532
      
  • Implementation is documented. Details:
    No changes to the documentation needed (change to fields in cabal).
  • Change history is clear.
  • Commit messages are clear.
  • Changelogs are updated.
  • Examples are updated. Details:
    No examples affected.
  • Required version bumps are evaluated. Details:
    No bump needed (but implemented by the change).

@ivanperez-keera
Copy link
Member Author

Change Manager: Implementation ready to be merged.

@ivanperez-keera ivanperez-keera added CR:Status:Closed Admin only: Change request that has been completed and removed CR:Status:Verification Admin only: Change request that is currently being verified labels Sep 8, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CR:Status:Closed Admin only: Change request that has been completed CR:Type:Management Admin only: Change request for conformance with policies or procedures
Development

No branches or pull requests

1 participant