Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BugFix] minor fix for FileParser #113

Merged
merged 2 commits into from
Jan 18, 2024
Merged

[BugFix] minor fix for FileParser #113

merged 2 commits into from
Jan 18, 2024

Conversation

laolarou726
Copy link
Member

@laolarou726 laolarou726 commented Jan 18, 2024

minor fix for FileParser, added retry operation


PR-Codex overview

Detailed summary

  • Updated the version of the SharpCompress package from 0.35.0 to 0.36.0.
  • Modified the SaveProfile method in the DefaultLauncherProfileParser class to retry writing the launcher profile file up to 3 times if there is an IOException.
  • Modified the RemoveAccount method in the DefaultLauncherAccountParser class to use a discard variable instead of assigning the value to a variable.
  • Modified the Save method in the DefaultLauncherAccountParser class to retry writing the launcher account file up to 3 times if there is an IOException.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@laolarou726 laolarou726 requested a review from BiDuang January 18, 2024 00:41
@laolarou726 laolarou726 added 漏洞 Bug 某些功能发生了异常 Something isn't working 新功能/改进 enhancement 增加新功能 New feature or request labels Jan 18, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@laolarou726 laolarou726 merged commit 16d6c5b into master Jan 18, 2024
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
漏洞 Bug 某些功能发生了异常 Something isn't working 新功能/改进 enhancement 增加新功能 New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants