Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix concurrent issue #140

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix concurrent issue #140

merged 2 commits into from
Apr 8, 2024

Conversation

laolarou726
Copy link
Member

@laolarou726 laolarou726 commented Apr 3, 2024 •
edited by pr-codex bot
Loading

PR-Codex overview

The focus of this PR is to add thread safety to DownloadHelper and DefaultLauncherProfileParser and DefaultLauncherAccountParser classes.

Detailed summary

  • Added thread safety using locks to methods in DefaultLauncherProfileParser and DefaultLauncherAccountParser
  • Removed System.Buffers import in DownloadHelper.cs
  • Added readonly object _lock to classes for synchronization

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@laolarou726 laolarou726 requested review from yueyinqiu and BiDuang April 3, 2024 23:51
yueyinqiu
yueyinqiu previously approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@yueyinqiu yueyinqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a ba a ba

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

yueyinqiu
yueyinqiu approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@yueyinqiu yueyinqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wu b wu b

@BiDuang
Copy link
Member

BiDuang commented Apr 8, 2024

smpp

@yueyinqiu
Copy link
Member

du l du l

@laolarou726
Copy link
Member Author

smjb, stop spamming

@laolarou726 laolarou726 merged commit 4e84ee2 into master Apr 8, 2024
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@yueyinqiu yueyinqiu yueyinqiu approved these changes

@BiDuang BiDuang Awaiting requested review from BiDuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laolarou726 @BiDuang @yueyinqiu