Deprecate PartialEq between Addr and String #1671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
deprecate-Addr-String
branch
from
e99f082 to
8f99179
Compare
maurolacy
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
LGTM. Isn't there a way to mark those impls as deprecated? https://stackoverflow.com/questions/30757914/can-i-mark-a-function-as-deprecated
I looked for it but it does not seem possible. There are some conversations around that, e.g. |
webmaster128
force-pushed
the
deprecate-Addr-String
branch
from
8f99179 to
08e5f88
Compare
|
I rebased this for the 1.2 branch such that it can be released as 1.2.x |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step for #1669