Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use bytes for reading Region from wasm memory #2005

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Use bytes for reading Region from wasm memory #2005

merged 4 commits into from
Jan 24, 2024

Conversation

chipshort
Copy link
Collaborator

will backport to 1.4 and 1.5 when approved

webmaster128
webmaster128 reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Could you add a CHANGELOG entry?

packages/vm/src/memory.rs Show resolved Hide resolved
packages/vm/src/memory.rs Show resolved Hide resolved
webmaster128
webmaster128 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@chipshort chipshort merged commit 226add5 into main Jan 24, 2024
29 checks passed
@chipshort chipshort deleted the use-bytes-for-reading-wasm branch January 24, 2024 13:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chipshort @webmaster128