Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IBC Fees messages #2196

Merged
merged 14 commits into from
Aug 9, 2024
Merged

IBC Fees messages #2196

merged 14 commits into from
Aug 9, 2024

Conversation

chipshort
Copy link
Collaborator

closes #2194

@chipshort chipshort requested a review from webmaster128 July 30, 2024 09:20
webmaster128
webmaster128 reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

packages/std/src/ibc.rs Show resolved Hide resolved
packages/std/src/ibc.rs Outdated Show resolved Hide resolved
packages/std/src/ibc.rs Outdated Show resolved Hide resolved
packages/std/src/ibc.rs Show resolved Hide resolved
@chipshort chipshort force-pushed the co/ibc-fees branch 3 times, most recently from d225860 to eda5f80 Compare August 7, 2024 13:51
@chipshort chipshort requested a review from webmaster128 August 7, 2024 13:57
@chipshort
Copy link
Collaborator Author

I addressed the comments and added the query to check whether a channel is fee enabled.

webmaster128
webmaster128 reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Some minor points and a CHANGELOR entry

packages/std/src/ibc.rs Show resolved Hide resolved
packages/std/src/ibc.rs Show resolved Hide resolved
packages/std/src/ibc.rs Show resolved Hide resolved
packages/std/src/ibc.rs Outdated Show resolved Hide resolved
packages/std/src/query/ibc.rs Outdated Show resolved Hide resolved
webmaster128
webmaster128 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@chipshort chipshort merged commit d1de10f into main Aug 9, 2024
30 of 32 checks passed
@chipshort chipshort deleted the co/ibc-fees branch August 9, 2024 11:24
@webmaster128 webmaster128 mentioned this pull request Aug 27, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IBC Fees
2 participants
@chipshort @webmaster128