Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move history of contract code migrations to their own prefix store. #196

Closed
4 tasks
alpe opened this issue Jul 16, 2020 · 2 comments · Fixed by #208
Closed
4 tasks

Move history of contract code migrations to their own prefix store. #196

alpe opened this issue Jul 16, 2020 · 2 comments · Fixed by #208

Comments

@alpe
Copy link
Contributor

alpe commented Jul 16, 2020

Summary

Move history of contract code migrations to their own prefix store. This would reduce the overhead in de-/serialization data for ContractInfo and save gas.

Follow up on #130


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ethanfrey
Copy link
Member

Good idea.

I think they can have a different prefix store, but one element per contract. Using the same address as key.

Definitely makes most queries much cheaper when there is much migration

@alpe
Copy link
Contributor Author

alpe commented Jul 20, 2020

👍 Another benefit is easier genesis ex-/ import as there is no need to import the history

zemyblue pushed a commit to Finschia/wasmd that referenced this issue Jan 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants