Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Split Connect/Close callbacks in IbcContract interface into 2 variants. #561

Closed
ethanfrey opened this issue Jul 26, 2021 · 2 comments · Fixed by #570
Closed

Split Connect/Close callbacks in IbcContract interface into 2 variants. #561

ethanfrey opened this issue Jul 26, 2021 · 2 comments · Fixed by #570
Milestone

Comments

@ethanfrey
Copy link
Member

Question: do we want to do so?

We use an argument to construct IbcConnectInit or IbcConnectTry from an IbcConnectOpen callback. We could split this into 2 methods, or we could use a IbcConnectOpenMsg as an argument (which captures the 2 variants).

It could definitely be cleaner than mine, which I did to make minimal changes. I'd like feedback from @alpe to do this.

@ethanfrey ethanfrey added this to the v0.18.0 milestone Jul 26, 2021
This was referenced Jul 26, 2021
@alpe
Copy link
Contributor

alpe commented Aug 2, 2021

The new types are cleaner in wasmd so I like them. Though they push the complexity of handling more cases upstream.

@ethanfrey
Copy link
Member Author

The work in cosmwasm is nice, such that you can call a helper msg.channel() to get the information common to both variants and not care about which one (as now), or actually switch on variant (if you care).

It is quite nice actually, from a fair bit of back and forth. At least it provides the contracts the possibility of handling the different events differently

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants