Better ibc contract interface #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
==========================================
+ Coverage 59.45% 59.71% +0.26%
==========================================
Files 45 45
Lines 5209 5208 -1
==========================================
+ Hits 3097 3110 +13
+ Misses 1882 1874 -8
+ Partials 230 224 -6
|
|
After merging this, I would cut a v0.18.0-rc1 as the remaining issues are mainly docs, with the possible change of an event type or two that we emit. Pretty close to release-ready API and something to cut CosmJS against |
webmaster128
approved these changes
Jul 28, 2021
| @@ -31,18 +31,6 @@ func (k Keeper) OnOpenChannel( | |||
| env := types.NewEnv(ctx, contractAddr) | |||
| querier := k.newQueryHandler(ctx, contractAddr) | |||
|
|
|||
| msg := wasmvmtypes.IBCChannelOpenMsg{} | |||
| if counterpartyVersion == "" { | |||
There was a problem hiding this comment.
Nice we don't need to rely on such logic anymore
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #561
We can make this less verbose once CosmWasm/wasmvm#254 is merged and tagger