Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Redesign IBC on packet recv error/ result.Err handling #1353

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Redesign IBC on packet recv error/ result.Err handling #1353

merged 1 commit into from
Apr 21, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Apr 21, 2023 •
edited
Loading

@alpe alpe force-pushed the ibc_packet_recv branch from b561461 to 7cd5893 Compare April 21, 2023 09:29
@alpe alpe requested review from pinosu and webmaster128 April 21, 2023 09:29
@alpe alpe added the backport/v0.3x Backport patches to sdk45 release branch label Apr 21, 2023
@alpe alpe mentioned this pull request Apr 21, 2023
Closed
pinosu
pinosu reviewed Apr 21, 2023
View reviewed changes
x/wasm/ibc_test.go
)

func TestOnRecvPacket(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good tests! 👍

pinosu
pinosu approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 👍

@alpe
Copy link
Contributor Author

alpe commented Apr 21, 2023

This is the last PR missing for a new RC on the 47 branch.
I will merge and tag now to unblock people. I would still appreciate feedback from you @webmaster128 . Let's use the backport branch for comments. Any changes will still go into main.

@alpe alpe merged commit c2bb27d into main Apr 21, 2023
@alpe alpe deleted the ibc_packet_recv branch April 21, 2023 16:36
@mergify mergify bot mentioned this pull request Apr 21, 2023
Merged
@alpe alpe mentioned this pull request Apr 21, 2023
Closed
alpe added a commit that referenced this pull request May 10, 2023
@mergify @alpe
Redesign IBC on packet recv error/ result.Err handling (backport #1353)…
70f077d 
… (#1358)

* Redesign IBC on packet recv error/ result.Err handling

(cherry picked from commit 7cd5893)

# Conflicts:
#	x/wasm/ibc.go
#	x/wasm/ibc_test.go
#	x/wasm/keeper/relay.go

* Resolve conflicts

* Apply review feedback (#1376)

* Apply review feedback

* Better test name

* Add contract integration test

* Better doc in test and minor refactoring

---------

Co-authored-by: Alex Peters <alpe@users.noreply.github.com>
@alpe alpe restored the ibc_packet_recv branch May 10, 2023 07:50
@alpe alpe deleted the ibc_packet_recv branch May 10, 2023 07:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pinosu pinosu pinosu approved these changes

@webmaster128 webmaster128 Awaiting requested review from webmaster128

Assignees
No one assigned
Labels
backport/v0.3x Backport patches to sdk45 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpe @pinosu