Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor: Improve error messages and type annotations in wasm types #2172

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Pronoss
Copy link

@Pronoss Pronoss commented Mar 18, 2025

  • Fixed typo in ErrMigrationFailed description (errors.go): updated wording from "execution" to "migration" failure
  • Explicitly defined the type for AllAccessTypes slice (params.go)
  • Replaced pkg/errors.Wrap() with errorsmod.Wrap() for consistency with Cosmos SDK error handling (params.go)

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.96%. Comparing base (65d332c) to head (4d65305).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2172   +/-   ##
=======================================
  Coverage   45.96%   45.96%           
=======================================
  Files          78       78           
  Lines       10684    10684           
=======================================
  Hits         4911     4911           
  Misses       5335     5335           
  Partials      438      438           
Files with missing lines Coverage Δ
x/wasm/types/errors.go 82.14% <ø> (ø)
x/wasm/types/params.go 70.73% <100.00%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant