Skip to content

Replace sdk.AccAddress with bech32 string #314

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 17, 2020

Resolves #306

@alpe alpe force-pushed the single_binary_308 branch from 3fbdbe3 to ca040da Compare November 17, 2020 11:55
@alpe alpe force-pushed the proto_account_strings_306 branch from 2519eaf to 6a92085 Compare November 17, 2020 12:20
@CosmWasm CosmWasm deleted a comment from codecov bot Nov 17, 2020
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

Base automatically changed from single_binary_308 to master November 17, 2020 12:44
@CosmWasm CosmWasm deleted a comment from codecov bot Nov 17, 2020
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #314 (0589dfa) into master (ca040da) will increase coverage by 0.12%.
The diff coverage is 26.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage   17.53%   17.65%   +0.12%     
==========================================
  Files          35       35              
  Lines       10519    10592      +73     
==========================================
+ Hits         1844     1870      +26     
- Misses       8572     8607      +35     
- Partials      103      115      +12     
Impacted Files Coverage Δ
x/wasm/internal/types/genesis.pb.go 0.66% <0.00%> (+<0.01%) ⬆️
x/wasm/internal/types/msg.pb.go 0.56% <0.00%> (+<0.01%) ⬆️
x/wasm/internal/types/proposal.pb.go 0.42% <0.00%> (+<0.01%) ⬆️
x/wasm/internal/types/query.pb.go 0.71% <0.00%> (+<0.01%) ⬆️
x/wasm/internal/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/wasm/internal/types/types.pb.go 0.76% <0.00%> (+<0.01%) ⬆️
x/wasm/internal/types/types.go 21.62% <25.00%> (-1.91%) ⬇️
x/wasm/handler.go 42.85% <26.41%> (-9.98%) ⬇️
x/wasm/internal/keeper/test_common.go 83.39% <26.66%> (-3.33%) ⬇️
x/wasm/internal/types/msg.go 53.00% <36.58%> (-11.64%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca040da...0589dfa. Read the comment docs.

@alpe alpe merged commit 24d9eaf into master Nov 17, 2020
@alpe alpe deleted the proto_account_strings_306 branch November 17, 2020 15:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use string type for AccAddresses in proto
2 participants