Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix chain id setup in contrib/local/setup_wasmd.sh #318

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

orkunkl
Copy link
Contributor

@orkunkl orkunkl commented Nov 19, 2020

The script did not use CHAIN_ID variable.

@orkunkl orkunkl requested a review from alpe November 19, 2020 08:01
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #318 (a6ea0c1) into master (807956b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   17.67%   17.65%   -0.02%     
==========================================
  Files          35       35              
  Lines       10592    10592              
==========================================
- Hits         1872     1870       -2     
- Misses       8606     8607       +1     
- Partials      114      115       +1     
Impacted Files Coverage Δ
x/wasm/internal/keeper/keeper.go 89.69% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 807956b...a6ea0c1. Read the comment docs.

@alpe
Copy link
Contributor

alpe commented Nov 19, 2020

Good 👁️ .
The $CHAIN_ID is not used in the other scripts in that folder but hard coded to testing. The only requirement so far was that it has to work on my box :-)
Do you have a use case where you want this different than testing ? I would suggest that this PR either removes the variable or also touches the other scripts. WDYT?

@orkunkl
Copy link
Contributor Author

orkunkl commented Nov 20, 2020

I was using to it set up a local chain named musselnet. not using docker. I found this bug and thought would be good to fix this.

@alpe alpe merged commit 8af8006 into master Nov 20, 2020
@alpe alpe deleted the setup-wasmd-script-fix branch November 20, 2020 12:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants