Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Exclude generate proto code files in coverage #320

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Exclude generate proto code files in coverage #320

merged 2 commits into from
Nov 20, 2020

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 20, 2020

Resolves #298

With this patch we just ignore the Go files generated by protobuf and some test files.

Most of this is copied from https://github.com/cosmos/cosmos-sdk/blob/master/.codecov.yml . Thanks 💐

@CosmWasm CosmWasm deleted a comment from codecov bot Nov 20, 2020
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #320 (3e52ef6) into master (8ee7038) will increase coverage by 51.86%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #320       +/-   ##
===========================================
+ Coverage   17.65%   69.51%   +51.86%     
===========================================
  Files          35       28        -7     
  Lines       10592     2316     -8276     
===========================================
- Hits         1870     1610      -260     
+ Misses       8607      598     -8009     
+ Partials      115      108        -7     
Impacted Files Coverage Δ
x/wasm/internal/types/query.pb.go
x/wasm/internal/types/types.pb.go
x/wasm/internal/types/query.pb.gw.go
x/wasm/internal/keeper/test_common.go
x/wasm/internal/types/proposal.pb.go
x/wasm/internal/types/genesis.pb.go
x/wasm/internal/types/msg.pb.go
x/wasm/internal/keeper/keeper.go 90.30% <0.00%> (+0.60%) ⬆️
x/wasm/internal/types/codec.go 45.83% <0.00%> (+0.67%) ⬆️

@alpe alpe requested a review from orkunkl November 20, 2020 11:20
Copy link
Contributor

@orkunkl orkunkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alpe alpe merged commit 16e88ec into master Nov 20, 2020
@alpe alpe deleted the codecov_298 branch November 20, 2020 12:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check codecov report
2 participants