Improve list contracts by code query #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
==========================================
- Coverage 58.45% 58.41% -0.04%
==========================================
Files 41 41
Lines 4441 4437 -4
==========================================
- Hits 2596 2592 -4
Misses 1631 1631
Partials 214 214
|
ethanfrey
reviewed
Apr 26, 2021
| CodeID: 1, | ||
| Created: &AbsoluteTxPosition{2 + 1<<(8*7), 3 + 1<<(8*7)}, |
There was a problem hiding this comment.
I would keep a different Created here just to prove it takes one and ignores the other.
There was a problem hiding this comment.
I have switched from ContractInfo to ContractCodeHistoryEntry element. Any instantiation/migration results in a new ContractCodeHistoryEntry so that it covers both.
webmaster128
approved these changes
Apr 27, 2021
ethanfrey
approved these changes
Apr 27, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #323
Breaking change:
List contracts by code returns now the addresses without other data from CodeInfo
This was a gas intensive query before. Especially with the legacy rest endpoint