Query all pinned code ids #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #633 +/- ##
==========================================
- Coverage 60.51% 60.21% -0.31%
==========================================
Files 48 48
Lines 5270 5313 +43
==========================================
+ Hits 3189 3199 +10
- Misses 1859 1889 +30
- Partials 222 225 +3
|
ethanfrey
approved these changes
Oct 7, 2021
There was a problem hiding this comment.
Looks good and great addition.
However, to fully close #596, I think you also need to add a pinned bool field to CodeInfoResponse. So we can see it when we look at a code by id.
Happy to merge this and then accept the minor addition as a new PR
|
|
||
| prefixStore := prefix.NewStore(ctx.KVStore(q.storeKey), types.PinnedCodeIndexPrefix) | ||
| pageRes, err := query.FilteredPaginate(prefixStore, req.Pagination, func(key []byte, _ []byte, accumulate bool) (bool, error) { | ||
| if accumulate { |
There was a problem hiding this comment.
I did not know of this accumulate flag. Nice use here
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #596
Note: no legacy query support for this query