-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Upgrade docker images in dockerfile #733
Conversation
alpe
commented
Jan 25, 2022
•
edited
Loading
edited
- Fixes failing docker build
- Enables docker build for all branches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting this is needed.
I need to dig into the genealogy of all the golang/alpine combinations sometime
Looking at the build failure... "Setup a remote docker engine"
Think this is a version issue? |
The last working one had the same docker engine |
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
==========================================
- Coverage 58.36% 58.32% -0.04%
==========================================
Files 49 49
Lines 5807 5807
==========================================
- Hits 3389 3387 -2
- Misses 2169 2170 +1
- Partials 249 250 +1
|
The "issue" was introduced with the alpine image upgrade. The remote docker version became incompatible. See https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0#faccessat2 for details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you merged without the filters.
We should get those back (one more PR before tagging)
branches: | ||
only: | ||
- master | ||
# filters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need these back!