Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade docker images in dockerfile #733

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Upgrade docker images in dockerfile #733

merged 1 commit into from
Jan 25, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jan 25, 2022

  • Fixes failing docker build
  • Enables docker build for all branches

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting this is needed.
I need to dig into the genealogy of all the golang/alpine combinations sometime

@ethanfrey
Copy link
Member

Looking at the build failure...

"Setup a remote docker engine"

Server Engine Details:
  Version:          17.09.0-ce
  API version:      1.32 (minimum version 1.12)
  Go version:       go1.8.3
  Git commit:       afdb6d4
  Built:            2017-09-26T22:40:56.000000000+00:00
  OS/Arch:          linux/amd64
  Experimental:     false

Think this is a version issue?

@ethanfrey
Copy link
Member

Bisecting when docker broke in master, I found this:

Screenshot 2022-01-25 at 13 22 30

@ethanfrey
Copy link
Member

The last working one had the same docker engine

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #733 (f15de7b) into master (d500cb3) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head f15de7b differs from pull request most recent head 848eb35. Consider uploading reports for the commit 848eb35 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
- Coverage   58.36%   58.32%   -0.04%     
==========================================
  Files          49       49              
  Lines        5807     5807              
==========================================
- Hits         3389     3387       -2     
- Misses       2169     2170       +1     
- Partials      249      250       +1     
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 87.54% <0.00%> (-0.36%) ⬇️

@alpe
Copy link
Contributor Author

alpe commented Jan 25, 2022

The "issue" was introduced with the alpine image upgrade. The remote docker version became incompatible. See https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0#faccessat2 for details

@alpe alpe marked this pull request as ready for review January 25, 2022 13:41
@alpe alpe requested a review from ethanfrey January 25, 2022 13:42
@alpe alpe merged commit de38ea0 into master Jan 25, 2022
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you merged without the filters.

We should get those back (one more PR before tagging)

branches:
only:
- master
# filters:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need these back!

@alpe alpe deleted the docker-build branch January 25, 2022 14:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants