Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add GH action to publish proto files to BSR #753

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Feb 11, 2022

Resolves #706

GH Action includes:

  • check for lint errors
  • check for backward compatibility breaking changes

Migrated buf config files from v1beta1 to v1 using command:
'buf config migrate-v1beta1'
(https://docs.buf.build/configuration/v1beta1-migration-guide)

@pinosu pinosu requested a review from alpe as a code owner February 11, 2022 09:16
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start.
I think the buf-breaking-action is very useful in the future.

.github/workflows/proto-buf-publisher.yml Show resolved Hide resolved
.github/workflows/proto-buf-publisher.yml Show resolved Hide resolved
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. ⛹️‍♂️

GH Action includes:
- check for lint errors
- check for backward compatibility breaking changes

Migrated buf config files from v1beta1 to v1 using command:
'buf config migrate-v1beta1'
(https://docs.buf.build/configuration/v1beta1-migration-guide)
@pinosu pinosu force-pushed the 706-publish_protobuf branch from 8833461 to 2ab0273 Compare February 11, 2022 11:43
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #753 (2ab0273) into master (33d768c) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
- Coverage   58.51%   58.47%   -0.04%     
==========================================
  Files          49       49              
  Lines        5828     5828              
==========================================
- Hits         3410     3408       -2     
- Misses       2169     2170       +1     
- Partials      249      250       +1     
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 87.54% <0.00%> (-0.36%) ⬇️

@pinosu pinosu requested a review from tac0turtle February 11, 2022 18:12
@tac0turtle
Copy link
Contributor

lgtm.

if you want to clean somethings up, you could remove 90% of https://github.com/CosmWasm/wasmd/tree/master/third_party/proto. Most these are not needed and may have been copied from cosmo-sdk.

@pinosu pinosu merged commit a6cb4c0 into master Feb 12, 2022
@alpe alpe deleted the 706-publish_protobuf branch May 10, 2023 08:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish protobuf files to https://buf.build/
3 participants