Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Restrict code access config modifications #901

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Restrict code access config modifications #901

merged 1 commit into from
Aug 23, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jul 8, 2022

Add some checks when wasmd is used as a library without gov.

@alpe alpe requested a review from pinosu July 8, 2022 12:32
@codecov
Copy link

codecov bot commented Jul 8, 2022 •
edited
Loading

Codecov Report

Merging #901 (e5ff7c1) into main (39be44b) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #901      +/-   ##
==========================================
+ Coverage   59.19%   59.29%   +0.09%     
==========================================
  Files          51       51              
  Lines        6196     6210      +14     
==========================================
+ Hits         3668     3682      +14     
  Misses       2262     2262              
  Partials      266      266
Impacted Files Coverage Δ
x/wasm/keeper/authz_policy.go 100.00% <100.00%> (ø)
x/wasm/keeper/contract_keeper.go 92.85% <100.00%> (ø)
x/wasm/keeper/keeper.go 88.62% <100.00%> (+0.05%) ⬆️
x/wasm/keeper/proposal_handler.go 66.66% <100.00%> (+0.22%) ⬆️
x/wasm/types/types.go 57.77% <100.00%> (+1.45%) ⬆️

pinosu
pinosu approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ethanfrey ethanfrey added this to the v0.29.0 milestone Aug 15, 2022
@alpe alpe merged commit 9d63bc0 into main Aug 23, 2022
@alpe alpe deleted the access_config branch August 23, 2022 15:03
@alpe alpe mentioned this pull request Aug 24, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pinosu pinosu pinosu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.29.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alpe @pinosu @ethanfrey