Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update types to cosmwasm 2.0 version #515

Merged
merged 8 commits into from
Feb 1, 2024
Merged

Update types to cosmwasm 2.0 version #515

merged 8 commits into from
Feb 1, 2024

Conversation

chipshort
Copy link
Collaborator

based on (and merging into) #509

I went through the 2.0 changelog and checked all types listed there. Hope I didn't miss anything.

webmaster128
webmaster128 reviewed Jan 31, 2024
View reviewed changes
types/ibc_test.go Show resolved Hide resolved
types/submessages.go Outdated Show resolved Hide resolved
@chipshort chipshort mentioned this pull request Feb 1, 2024
Merged
webmaster128
webmaster128 reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice. We need a paragraph on MIGRATING for this since callers have to be changes

types/types.go Show resolved Hide resolved
types/types_test.go Show resolved Hide resolved
types/types.go Outdated Show resolved Hide resolved
@chipshort chipshort force-pushed the 490-update-cosmwasm branch from 6c016ab to 0009ee3 Compare February 1, 2024 14:55
@chipshort
Copy link
Collaborator Author

I rebased this, changed the Array to deserialize to empty slice for null and [], added the test cases and added some more documentation and migrating info. I think this can be rereviewed.

Base automatically changed from 490-update-cosmwasm to main February 1, 2024 15:06
webmaster128
webmaster128 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice

@chipshort chipshort merged commit 7a6da63 into main Feb 1, 2024
13 checks passed
@chipshort chipshort deleted the update-types branch February 1, 2024 16:54
@chipshort chipshort mentioned this pull request Feb 5, 2024
Closed
10 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chipshort @webmaster128