Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[v16] TokenFactory Validation Migration #730

Merged
merged 6 commits into from
Jun 27, 2023

Conversation

Reecepbcups
Copy link
Contributor

@Reecepbcups Reecepbcups commented Jun 23, 2023

Closes #719
Per sei-protocol/sei-chain#861

When new tokens are created, some of the bank metadata is not set by default. This causes x/bank's genesis validation to fail on a hard fork of the mainnet genesis.

Task:

  • Migrate all TF denoms without Display to have the required metadata
  • Test to ensure different token-factory states properly convert (e2e upgrade)
    • denom, no supply
    • denom with supply
    • denom with supply with set metadata (ex: junod tx tokenfactory modify-metadata already)

@Reecepbcups Reecepbcups changed the title TokenFactory Validation Migration [v16] TokenFactory Validation Migration Jun 24, 2023
@Reecepbcups Reecepbcups marked this pull request as ready for review June 24, 2023 00:34
Copy link

@0xstepit 0xstepit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reecepbcups Reecepbcups merged commit d287a99 into main Jun 27, 2023
@Reecepbcups Reecepbcups mentioned this pull request Jul 7, 2023
12 tasks
@joelsmith-2019 joelsmith-2019 deleted the reece/tf-validation-migrate branch February 2, 2024 21:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Tokenfactory exports not a valid genesis
3 participants