Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use AnyObject instead of deprecated class for protocol #86

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Use AnyObject instead of deprecated class for protocol #86

merged 1 commit into from
Apr 28, 2021

Conversation

yageek
Copy link
Contributor

@yageek yageek commented Apr 27, 2021

Use AnyObject instead of deprecated class for protocol

@PlugNPush PlugNPush self-requested a review April 28, 2021 12:40
PlugNPush
PlugNPush approved these changes Apr 28, 2021
View reviewed changes
Copy link
Collaborator

@PlugNPush PlugNPush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class is not formally deprecated and behaves in this case exactly like AnyClass. There is absolutely no urgency to merge this PR, but I don't see any inconvenient switching to AnyObject on my side.

@victor-sarda
Copy link
Collaborator

class is not formally deprecated and behaves in this case exactly like AnyClass. There is absolutely no urgency to merge this PR, but I don't see any inconvenient switching to AnyObject on my side.

Even if compiler doesn’t throw any warning, class is actually deprecated since Swift 4 and using AnyObject is a recommended practice now. I'm happy to merge this 👍

See:

@victor-sarda victor-sarda added this to the 1.0.2 milestone Apr 28, 2021
@victor-sarda victor-sarda merged commit 7f50926 into CovidTrackerFr:develop Apr 28, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@victor-sarda victor-sarda victor-sarda approved these changes

@PlugNPush PlugNPush PlugNPush approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@yageek @victor-sarda @PlugNPush