Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Optimize hashtable loading #216

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

Morilli
Copy link
Collaborator

@Morilli Morilli commented Aug 4, 2023

Just a bit of free optimization for the hashtable loading, as that does take a significant amount of time, mainly loading hashes.game.txt.

In my basic testing, this reduces loading time of the hashes.game.txt file from ~1.5s to ~1.2s, while also reducing total memory allocations from ~920MB to ~600MB.

I've used two different methods here, a more readable and simple and slightly less optimal for bin hashtable loading, and a more optimized one for game/lcu hashtable loading.

@Crauzer Crauzer merged commit 2549e52 into Crauzer:main Aug 6, 2023
@Morilli Morilli deleted the optimize-hashtable-loading branch August 6, 2023 01:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants