Fix test suite failure when no tf wheel #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #291 +/- ##
===========================================
+ Coverage 87.65% 87.77% +0.12%
===========================================
Files 58 58
Lines 3322 3322
===========================================
+ Hits 2912 2916 +4
+ Misses 410 406 -4 |
mellis13
approved these changes
May 25, 2023
mellis13
approved these changes
May 25, 2023
mellis13
approved these changes
May 25, 2023
|
Just a quick question on this -- is it worth noting in the change log that we fixed this bug? |
Certainly couldn't hurt in case anyone user was running into this issue. I'll throw in a quick mention |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves test module
test_dbmodel.pyusing symbols from a TF import statement that may not be present at test time (e.g. if a user installs w/o ml backends and then runsmake test-full)