Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

casting issues for nightlies #310

Merged
merged 6 commits into from
Jun 28, 2023
Merged

casting issues for nightlies #310

merged 6 commits into from
Jun 28, 2023

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Jun 27, 2023

Fix two defects created in the typehinting PRs:

  1. The job-id was cast to an integer and should have been a string
  2. A test for task_id having a null-or-zero value was added to incorrectly guard against adding steps without task_id from being added to history

@ankona ankona requested review from MattToast and mellis13 June 27, 2023 16:46
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #310 (ce7632a) into develop (e6e563a) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #310   +/-   ##
========================================
  Coverage    87.54%   87.54%           
========================================
  Files           59       59           
  Lines         3461     3461           
========================================
  Hits          3030     3030           
  Misses         431      431           
Impacted Files Coverage Δ
smartsim/_core/launcher/launcher.py 100.00% <ø> (ø)
smartsim/_core/control/job.py 93.42% <100.00%> (ø)
smartsim/_core/control/jobmanager.py 94.30% <100.00%> (ø)
smartsim/_core/launcher/stepMapping.py 74.41% <100.00%> (ø)

@ankona ankona marked this pull request as ready for review June 27, 2023 19:30
@MattToast MattToast self-requested a review June 27, 2023 19:46
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question, but otherwise lgtm!

@ankona ankona requested a review from MattToast June 27, 2023 21:57
@ankona ankona merged commit 7d4abee into CrayLabs:develop Jun 28, 2023
@ankona ankona deleted the jobid-cast branch June 28, 2023 16:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants