Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Log sacct failures #331

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Log sacct failures #331

merged 2 commits into from
Aug 1, 2023

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Aug 1, 2023

After experiencing a crash in the slurm database, tests began failing unexpectedly. This fix ensures that a warning will be logged if the database goes down again.

@ankona ankona requested review from ashao and mellis13 August 1, 2023 15:27
@ankona ankona self-assigned this Aug 1, 2023
@ankona ankona added area: launcher Issues related to any of the launchers within SmartSim type: usability Issues related to ease of use short task Issues that can be completed and reviewed quickly labels Aug 1, 2023
Copy link
Collaborator

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ankona! This will help differentiate what might be a SmartSim problem versus a problem that might be a result of system defect.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #331 (8fb60b8) into develop (c8ea7ea) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #331   +/-   ##
========================================
  Coverage    87.32%   87.32%           
========================================
  Files           59       59           
  Lines         3526     3526           
========================================
  Hits          3079     3079           
  Misses         447      447           

@mellis13 mellis13 changed the title log sacct failures Log sacct failures Aug 1, 2023
@ankona ankona merged commit 8ce3c1d into CrayLabs:develop Aug 1, 2023
@ankona ankona deleted the sacct-rpt branch April 4, 2024 19:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area: launcher Issues related to any of the launchers within SmartSim short task Issues that can be completed and reviewed quickly type: usability Issues related to ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants