Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable mypy generic-related checks #338

Merged
merged 6 commits into from
Aug 9, 2023
Merged

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Aug 7, 2023

Enable disallow_any_generics and warn_return_any in pyproject.toml and mitigate issues that were identified.

@ankona ankona requested a review from MattToast August 7, 2023 16:35
@ankona ankona changed the title Enable mypy disallow_any_generics check Enable mypy generic-related checks Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #338 (442d97e) into develop (1d2ec9f) will increase coverage by 0.06%.
The diff coverage is 78.94%.

❗ Current head 442d97e differs from pull request most recent head ea3d5a0. Consider uploading reports for the commit ea3d5a0 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #338      +/-   ##
===========================================
+ Coverage    87.20%   87.27%   +0.06%     
===========================================
  Files           59       59              
  Lines         3526     3535       +9     
===========================================
+ Hits          3075     3085      +10     
+ Misses         451      450       -1     
Files Changed Coverage Δ
smartsim/_core/utils/helpers.py 82.60% <ø> (ø)
smartsim/_core/launcher/taskManager.py 79.06% <57.14%> (+1.82%) ⬆️
smartsim/_core/utils/redis.py 86.27% <75.00%> (-0.96%) ⬇️
smartsim/_core/control/controller.py 84.15% <100.00%> (ø)
smartsim/database/orchestrator.py 83.91% <100.00%> (ø)
smartsim/ml/data.py 94.14% <100.00%> (ø)
smartsim/ml/tf/data.py 88.63% <100.00%> (ø)
smartsim/settings/settings.py 74.19% <100.00%> (ø)

@ankona ankona requested a review from mellis13 August 8, 2023 16:38
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small questions, but otherwise LGTM!!

@ankona ankona merged commit 6125f3c into CrayLabs:develop Aug 9, 2023
@MattToast MattToast added the area: CI/CD Issues related to continuous integration and deployment label Sep 13, 2023
@ankona ankona deleted the oss340 branch April 4, 2024 19:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area: CI/CD Issues related to continuous integration and deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants