-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove Cobalt support #448
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #448 +/- ##
===========================================
+ Coverage 90.34% 90.80% +0.46%
===========================================
Files 60 60
Lines 3833 3830 -3
===========================================
+ Hits 3463 3478 +15
+ Misses 370 352 -18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to LGTM!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The only suggestion, which may have been discussed while I was away, is to throw a more informative error if someone specifically tried to request the cobalt launcher. I wouldn't even give it it's own dummy class, just throw it on the instantiation of Experiment
, i.e.
if launcher == "cobalt":
raise SSUnsupportedError("Support for the Cobalt launcher is no longer supported")
Co-authored-by: Matt Drozt <matthew.drozt@gmail.com>
Slightly reworded and added to |
As we are not aware of any system still using the Cobalt workload manager, its support in SmartSim was terminated. [ committed by @al-rigazzi ] [ reviewed by @MattToast @ashao ]
With the retirement of Theta, we are not aware of any other system using Cobalt as a workload manager. Therefore, this PR removes support for Cobalt.