Quality of life smart validate Improvements
#458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set `CUDA_VISIBLE_DEVICES` environment variable within `smart validate` prioro to importing any ML deps to prevent false negatives on multi-GPU systems - Move SmartRedis logs from standard out to dedicated log file in the validation temporary directory - Suppress `sklearn` deprecation warning by pinning `KMeans` constructor argument
al-rigazzi
approved these changes
Jan 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #458 +/- ##
===========================================
+ Coverage 90.42% 90.80% +0.38%
===========================================
Files 60 60
Lines 3738 3830 +92
===========================================
+ Hits 3380 3478 +98
+ Misses 358 352 -6 |
ashao
approved these changes
Jan 19, 2024
ashao
reviewed
Jan 19, 2024
smartsim/_core/_cli/validate.py
Outdated
| if with_pt: | ||
| logger.info("Verifying Torch Backend") | ||
| _test_torch_install(client, device) | ||
| if with_tf: |
There was a problem hiding this comment.
If this fixes the problem we found, could you move the Tensorflow test to the very end?
ashao
pushed a commit
to ashao/SmartSim
that referenced
this pull request
Jan 27, 2024
Quality of life `smart validate` improvements: - Set `CUDA_VISIBLE_DEVICES` environment variable within `smart validate` prior to importing any ML deps to prevent false negatives on multi-GPU systems - Move SmartRedis logs from standard out to dedicated log file in the validation temporary directory - Suppress `sklearn` deprecation warning by pinning `KMeans` constructor argument - Move TF test to last as TF may reserve the GPUs it uses [ committed by @MattToast ] [ reviewed by @al-rigazzi @ashao ]
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quality of life
smart validateimprovements:CUDA_VISIBLE_DEVICESenvironment variable withinsmart validateprior to importing any ML deps to prevent false negatives on multi-GPU systemssklearndeprecation warning by pinningKMeansconstructor argument