Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed Typehint for RunSettings.colocated_db_settings #462

Merged
merged 19 commits into from
Jan 29, 2024

addressing matt comments

73495ab
Select commit
Loading
Failed to load commit list.
Merged

Fixed Typehint for RunSettings.colocated_db_settings #462

addressing matt comments
73495ab
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2024 in 0s

81.42% (target 0.00%)

View this Pull Request on Codecov

81.42% (target 0.00%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c38f73f) 90.42% compared to head (73495ab) 81.42%.
Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #462      +/-   ##
===========================================
- Coverage    90.42%   81.42%   -9.00%     
===========================================
  Files           60       60              
  Lines         3738     3834      +96     
===========================================
- Hits          3380     3122     -258     
- Misses         358      712     +354     
Files Coverage Δ
smartsim/_core/control/controller.py 78.48% <ø> (-8.65%) ⬇️
smartsim/_core/launcher/step/step.py 98.46% <100.00%> (ø)
smartsim/entity/model.py 78.84% <100.00%> (-16.58%) ⬇️
smartsim/settings/base.py 98.27% <100.00%> (+<0.01%) ⬆️

... and 23 files with indirect coverage changes