Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix util-tests outputs appearing in root directory #614

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fix util-tests outputs appearing in root directory #614

merged 2 commits into from
Jun 13, 2024

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Jun 12, 2024 •
edited
Loading

Fix unit tests that omit an experiment path and write to the root directory of the project.

Secondary Changes

  • Added typehints to enable successfully passing mypy test_manifest.py
  • Refactored test using global variables in pytest parameterization to use a fixture

@ankona ankona requested a review from MattToast June 12, 2024 20:42
MattToast
MattToast approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending tests! Thanks for handling this!!

@ankona ankona merged commit 34987e7 into CrayLabs:develop Jun 13, 2024
34 checks passed
@ankona ankona deleted the util-test-fix branch June 13, 2024 14:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MattToast MattToast MattToast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankona @MattToast