Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement backup and restore without storage permission #94

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

unbiaseduser
Copy link
Contributor

Hello. So, I have seen that this app advertises backup/restore feature but that functionality is missing in the actual app. Thus, I decided to look around in the code and I found out that the backup/restore code was actually present, but it seems to be tied to the storage permission. I have ported the code to use the ActivityResultContracts API, which requires no permission. I hope you can take a look at it.

@CrazyMarvin
Copy link
Contributor

That's awesome, @unbiaseduser! Thank you very much.
Please check if we can merge it, @arafaatqureshi.

@arafaatqureshi
Copy link
Contributor

@unbiaseduser Thank you so much for your input, i was still working with the same issue. Highly appreciated.
Let me go through your code, will merge it after that :)

@unbiaseduser
Copy link
Contributor Author

@arafaatqureshi Any progress so far? This is taking a bit too long for a simple change.
Keep in mind that it is you who wrote the main backup/restore code and I just adapted it a little bit.
I really don't think that it should take days for you to review...

@arafaatqureshi arafaatqureshi merged commit 926f3dd into Crazy-Marvin:development Sep 21, 2022
@unbiaseduser
Copy link
Contributor Author

Oh thank you, good sir. I was worrying you would be inactive.

@CrazyMarvin CrazyMarvin linked an issue Sep 23, 2022 that may be closed by this pull request
@CrazyMarvin CrazyMarvin mentioned this pull request Oct 3, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of All files access (MANAGE_EXTERNAL_STORAGE) permission
4 participants