fix: parse body when unsupported HTTP/2 upgrade is requested #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crow does not support HTTP/2 at the moment. According to the RFC https://datatracker.ietf.org/doc/html/rfc7540#section-3.2 "A server that does not support HTTP/2 can respond to the request as though the Upgrade header field were absent"
mrozigor
approved these changes
Mar 16, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the RFC https://datatracker.ietf.org/doc/html/rfc7540#section-3.2 "A server that does not support HTTP/2 can respond to the request as though the Upgrade header field were absent"
Crow does not support HTTP/2 at the moment, however when an upgrade is requested the body of the request is not parsed.
This commit fixes that.
See the tests for a request that triggers this behavior.