Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[ DOC ] QuickScan Pro upload file operation name is incorrect #1277

Closed
3 tasks
carlosmmatos opened this issue Feb 3, 2025 · 3 comments · Fixed by #1282
Closed
3 tasks

[ DOC ] QuickScan Pro upload file operation name is incorrect #1277

carlosmmatos opened this issue Feb 3, 2025 · 3 comments · Fixed by #1282
Assignees
@jshcodes
Labels
documentation 📖 Improvements or additions to documentation

Comments

@carlosmmatos
Copy link
Contributor

Documentation page topic
Quick Scan Pro / UploadFileMixin0Mixin93

Describe the error or typo
This is using the incorrect API Operation name. It should be

- UploadFileMixin0Mixin93
+ UploadFileMixin0Mixin94

You can see this from:

falconpy/src/falconpy/quick_scan_pro.py

Line 96 in eaf227b

operation_id="UploadFileMixin0Mixin94",

Documentation repository:

  • GitHub Wiki
  • falconpy.io
  • Source code - docstring

Additional context
My guess is that we shouldn't be using UploadFileMixin0Mixin93 in this operation at all...
@carlosmmatos carlosmmatos added the documentation 📖 Improvements or additions to documentation label Feb 3, 2025
@carlosmmatos carlosmmatos changed the title [ DOC ] ... [ DOC ] QuickScan Pro upload file operation name is incorrect Feb 3, 2025
@carlosmmatos
Copy link
Contributor Author

I would also highlight here that it should be: QuickScan Pro, not Quick Scan Pro

@carlosmmatos carlosmmatos mentioned this issue Feb 3, 2025
Closed
@jshcodes jshcodes self-assigned this Feb 10, 2025
@jshcodes
Copy link
Member

Operation ID has been updated to match the latest operation ID released: UploadFileQuickScanPro. Replicated to https://falconpy.io.

@jshcodes
Copy link
Member

I would also highlight here that it should be: QuickScan Pro, not Quick Scan Pro

Service Collection names are based off of the category posted to swagger.

@jshcodes jshcodes reopened this Feb 12, 2025
jshcodes added a commit that referenced this issue Feb 12, 2025
@jshcodes
Description updates. Operation ID Update (UploadFileQuickScanPro). Cl…
dc44f74 
…oses #1277.
@jshcodes jshcodes mentioned this issue Feb 12, 2025
Merged
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jshcodes jshcodes

Labels
documentation 📖 Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 1.4.7 - Correlation Rules, Intelligence Feeds and NG-SIEM CrowdStrike/falconpy
2 participants
@carlosmmatos @jshcodes