Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[IT] Fixing translations + adding lesson 11 #690

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

lonasozo
Copy link

@lonasozo lonasozo commented Aug 4, 2022

Translation improvement

  • [✓ ] I did these translations myself and own copyright for them
  • [ ✓] I didn't use a machine to do these translations
  • [ ✓] I assign all copyright to Loom Network for these translations

@lonasozo lonasozo changed the title Update 3-msgsender.md Update ITA translations Aug 4, 2022
@lonasozo lonasozo marked this pull request as draft August 7, 2022 07:37
@lonasozo lonasozo changed the title Update ITA translations Update ITA translations (in progress) Aug 7, 2022
@lonasozo lonasozo changed the title Update ITA translations (in progress) [IT] Update translations (in progress) Aug 7, 2022
Fixed wrong suggestion inside description in step 2 
request -> require
English text removed
English text removed
fixed typo: missed space from two words
Code specification to solve the quest has been translated, got error while submit them. Removed translation on them.
Code specification translated and error on submit of the code, removed.
@lonasozo
Copy link
Author

lonasozo commented Aug 7, 2022

Found that after the /6, the /11 and others (that are available on the website) has not been translated and files does not exists.
I'll work on it.
In the while if you want to merge these fixes, let me know and I'll change the PR from draft to open, creation and translation of missed chapters can be done next (requires a little bit of time to be done).

@lonasozo lonasozo changed the title [IT] Update translations (in progress) [IT] Updating/Adding translations (in progress) Aug 12, 2022
@lonasozo lonasozo changed the title [IT] Updating/Adding translations (in progress) [IT] Updating/Adding translations Aug 12, 2022
@lonasozo lonasozo changed the title [IT] Updating/Adding translations [IT] Fixing translations + adding lesson 11 Aug 12, 2022
@lonasozo lonasozo marked this pull request as ready for review August 12, 2022 15:27
Copy link

@Liiuc Liiuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the translations, pretty good overall !

Liiuc
Liiuc approved these changes Oct 18, 2022
@p-lorenzo
Copy link

p-lorenzo commented Oct 18, 2022

I was about to create a PR with some of the translation issues you fixed, LGTM

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants