Use Closures for registering blocks #37
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to solve two big problems with the
CustomiesBlockFactory->registerBlock()
API:BlockIdentifierFlattened
whereas we only accept aBlockIdentifier
, meaning the user needs to create a new class that inherits the same behaviour to use within Customies.SlabType
is an enum which implements theNotSerializable
trait.The solution to both of these problems is instead of accepting a class name along with other information such as
BlockBreakInfo
, we instead accept a single Closure which returns an instance of the Block. This allows for blocks to be constructed however they are needed, and also removes the requirement for serializing the Block objects to register them on other threads.