Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

D3DDevice_BeginPush(2) inaccurate name setup #192

Closed
RadWolfie opened this issue Mar 3, 2023 · 1 comment · Fixed by #193
Closed

D3DDevice_BeginPush(2) inaccurate name setup #192

RadWolfie opened this issue Mar 3, 2023 · 1 comment · Fixed by #193

Comments

@RadWolfie
Copy link
Member

RadWolfie commented Mar 3, 2023 •
edited
Loading

I found out D3DDevice_BeginPush(2) are actually one function and not additional function that reside with it. With that said, the following rename is require:

  • D3DDevice_BeginPush2 to D3DDevice_BeginPush_8 (first introduction)
  • D3DDevice_BeginPush to D3DDevice_BeginPush_4 (changed later on)

And update unit test to combine both symbols as one.
@RadWolfie
Copy link
Member Author

fixed in #193

@RadWolfie RadWolfie linked a pull request Mar 6, 2023 that will close this issue
Another D3D8(LTCG) signatures update #193
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Another D3D8(LTCG) signatures update RadWolfie/XbSymbolDatabase
1 participant
@RadWolfie